acceptance: add photon-false pipeline test#5434
Merged
Merged
Conversation
Records what terraform and direct engines send when `photon: false` is explicitly set on a pipeline. The direct engine correctly includes `"photon": false` in the request; terraform omits it. Co-authored-by: Isaac
Collaborator
|
Commit: 93a53e1 |
Co-authored-by: Isaac
Co-authored-by: Isaac
pietern
approved these changes
Jun 5, 2026
Chambras
pushed a commit
to Chambras/newDatabrickscli
that referenced
this pull request
Jul 6, 2026
Extend databricks#5434 (`photon-false`) with `serverless: false` and `continous: false` The test now also dump `bundle.tf.json` when present, showing the CLI writes the `false` value correctly — it is the Terraform provider that drops it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
photon: falseon a DLT pipeline, recording the HTTP requests made by both theterraformanddirectdeployment engines.photon: falseis explicitly set, the direct engine correctly includes"photon": falsein the API request, but the terraform engine silently omits the field (treatingfalseas the default and not sending it).num-workers-zerotest pattern.Test plan
go test ./acceptance -run TestAccept/bundle/resources/pipelines/photon-falsepasses for both engine variantsThis pull request was AI-assisted by Isaac.